This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [04/09] Get rid of current_gdbarch (SIZEOF_FRAME_SAVED_REGS macro)
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: deuling at de dot ibm dot com
- Cc: gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
- Date: Mon, 5 Nov 2007 14:43:29 +0100 (CET)
- Subject: Re: [rfc] [04/09] Get rid of current_gdbarch (SIZEOF_FRAME_SAVED_REGS macro)
- References: <472F0AC9.7030700@de.ibm.com>
> Date: Mon, 05 Nov 2007 13:21:29 +0100
> From: Markus Deuling <deuling@de.ibm.com>
>
> Hi,
>
> this patch replaces SIZEOF_FRAME_SAVED_REGS macro by its expression.
>
> Tested by gdb_mbuild with alpha target. Is this ok to commit?
I'm not thrilled, since this replaces a #define that has a sensible
name with some sort of complicated expression, and therefore makes the
code much more difficult to read.
> ChangeLog:
>
>
> * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Replace
> SIZEOF_FRAME_SAVED_REGS by its expression. Use get_frame_arch to get at
> the current architecture by frame_info.
> * alpha-tdep.c (alpha_heuristic_frame_unwind_cache): Likewise.
> * frame.h (SIZEOF_FRAME_SAVED_REGS): Remove.