This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Improve NetBSD/i386 signal trampoline detection
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Hudson <nick dot hudson at dsl dot pipex dot com>
- Cc: gdb-patches at sourceware dot org, Mark Kettenis <kettenis at gnu dot org>
- Date: Thu, 11 Oct 2007 14:04:28 -0400
- Subject: Re: [rfc] Improve NetBSD/i386 signal trampoline detection
- References: <200710021207.16451.nick.hudson@dsl.pipex.com>
On Tue, Oct 02, 2007 at 12:07:15PM +0100, Nick Hudson wrote:
> Hi,
>
> I put together this patch to improve NetBSD/i386 signal trampoline detection.
> I believe tramp_frame is a better and preferred method.
>
> I think I need to add the instructions for when the setcontext/sigreturn fails
> as well. Is this correct?
>
> Any/all comments appreciated.
Trivial comments: you've added #includes so Makefile.in needs an
update (maybe I'll do automatic dependencies sometime soon); please
include a ChangeLog with all patches; do you have a copyright
assignment?
Does this fix a problem, or are you just cleaning up?
As for the patch itself I'm hoping Mark Kettenis can look at it; he's
both the i386 port and FreeBSD maintainer, which is not all that close
to an i386-netbsd maintainer but it's the closest we have.
--
Daniel Jacobowitz
CodeSourcery