This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Fix wrong critical complaint in ARI about strerror
- From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Daniel Jacobowitz'" <drow at false dot org>
- Date: Mon, 8 Oct 2007 17:20:02 +0200
- Subject: [RFA] Fix wrong critical complaint in ARI about strerror
This patch fixed a problem of a false critical bug
related to strerror.
Following a change of 2006-02-10 from Daniel,
safe_strerror is not defined in gdb/utils.c anymore,
but two different versions are defined in
mingw-hdep.c and posix-hdep.c
This causes ARI to complain, both about two
misuses of strerror, and about the missing call of
strerror in gdb/utils.c
The following fix removes all strerror complaints in ARI.
Daniel, could you commit this, please?
Pierre
ChangeLog pseudo-entry:
2007-10-08 Pierre Muller <muller@ics.u-strasbg.fr>
* gdb_ari.sh (strerror): update rule to reflect
implementation of safe_strerror in posix-hdep.c and mingw-hdep.c.
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.74
diff -u -p -r1.74 gdb_ari.sh
--- gdb_ari.sh 8 Oct 2007 12:01:35 -0000 1.74
+++ gdb_ari.sh 8 Oct 2007 15:12:38 -0000
@@ -488,7 +488,8 @@ BEGIN { doc["strerror"] = "\
Do not use strerror(), instead use safe_strerror()"
category["strerror"] = ari_regression
fix("strerror", "gdb/gdb_string.h", 1)
- fix("strerror", "gdb/utils.c", 1)
+ fix("strerror", "gdb/mingw-hdep.c", 1)
+ fix("strerror", "gdb/posix-hdep.c", 1)
}
/(^|[^_[:alnum:]])strerror[[:space:]]*\(/ {
fail("strerror")
Pierre Muller
Chargé de recherches
Institut Charles Sadron
6, rue Boussingault
F 67083 Strasbourg Cedex
Tél.?: +(33)3-88-41-40-07
Email?: pierre.muller@ics.u-strasbg.fr