This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR pascal/2283



On 26 Sep 2007, at 15:49, Eli Zaretskii wrote:


From: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: "'Jonas Maebe'" <jonas@freepascal.org>
Date: Wed, 26 Sep 2007 14:25:38 +0200

-              || ((current_language->la_language == language_m2)
+              || ((current_language->la_language == language_pascal)

Why is it TRT to remove Modula-2 here?

Because the that code resides in pascal_val_print() in p-valprint.c, and not in m2_val_print() in m2-valprint.c (the former was based on the latter, and the leftover language_m2 was simply a copy/paste error afaics).


In fact, I have no idea why that code (in both the Pascal and Modula-2 cases) even checks the current language, as those routines are obviously language-specific. Maybe the Modula-2 code originally came from a generic routine, and the check was never removed (and then copied over to the Pascal version when that one was written)?


Jonas



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]