This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] tui: initialize signal handler
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 22 Sep 2007 09:34:30 +0200
- Subject: Re: [patch] tui: initialize signal handler
- References: <46F46E9E.5070003@linux.vnet.ibm.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 21 Sep 2007 22:23:42 -0300
> From: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
>
> I noticed that the TUI signal handler isn't initialized anywhere. Here's
> a patch to fix it.
Thanks.
> What do you think?
I think it shouldn't use sigaction unconditionally, as the rest of GDB
doesn't. It should at least test HAVE_SIGACTION and include an
alternative solution for when sigaction is not available. See
remote-fileio.c for an example.