This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/commit] Getting rid of tm-rs6000.h (PROCESS_LINENUMBER_HOOK)


> Date: Wed, 19 Sep 2007 23:37:14 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hi Mark,
> 
> > > The AIX port is the only port that defines this macro, and it's only
> > > used in one place: buildsym.c:end_symtab(). I think the most appropriate
> > > way to define this notion is as a gdbarch method, set only in the case
> > > of AIX. This is what this patch does.
> > 
> > Hmm, if this is something that is purely for a specific object/debug format,
> > I think the gdbarch vector is the wrong place to put it.
> 
> Since the gdbarch vector is dependent on the ABI, we can set the method
> when identifying XCOFF objects. That seemed the simplest approach at
> the time.  But I agree that this is borderline. What do you think about
> adding a new method inside struct sym_fns: 
> 
>         void (*sym_read_linetable) (void)
> 
> It would be null for all object formats except XCOFF.
> 
> I'll experiment with that... Thanks for your feedback!

Seems like a better approach to me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]