Re: [patch 0/1] Threaded Watchpoints

[Luis Machado <luisgpm at linux dot vnet dot ibm dot com>]

Hi,

> If that doesn't help, could you show me the error message?  Thanks.

Yes, that does it, though it doesn't look right to have that definition
moved to "linux-nat.c". But i might have outdated include files (when
were they changed?), so the current code should be fine except for this
particular piece:

==== code ====
static int
-ppc_linux_stopped_by_watchpoint (void)
+ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR
*addr_p)
 {
-  int tid;
-  struct siginfo siginfo;
-  ptid_t ptid = inferior_ptid;
+  struct siginfo *siginfo_p;
   CORE_ADDR *addr_p;

-  tid = TIDGET(ptid);
-  if (tid == 0)
-    tid = PIDGET (ptid);
=== code ===

We should get rid of the locally-defined "addr_p" since it's already
being passed as a parameter by "stopped_data_address".

I've built GDB, tried to insert a watchpoint after creating 10 threads
and the those threads triggered correctly.

As for the testcases, since PPC only supports one hardware watchpoint
per process, we should work that test case in a different way or mark it
as unsupported for PPC and write a different test case.

Regards,

-- 
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com