This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] MI and MI2 should have identical behavior on -target-download command
- From: Maxim Grigoriev <maxim at tensilica dot com>
- To: gdb-patches at sources dot redhat dot com, Pete MacLiesh <pmac at tensilica dot com>, Marc Gauthier <marc at tensilica dot com>, Ross Morley <ross at tensilica dot com>
- Date: Mon, 20 Aug 2007 14:03:59 -0700
- Subject: [PATCH] MI and MI2 should have identical behavior on -target-download command
This patch has to be approved before I can commit it.
It fixes a small glitch in GDB MI. MI2 is a default. So
MI and MI2 should work identically. The MI2 being set as
a default is hard-coded in several places. I think one
place was missed:
mi/mi-main.c::mi_load_progress().
Without this fix, MI "-target-download" command behaves
differently on MI versus MI2 not showing loading progress,
when "-i=mi2" is used.
GDB front-ends developers might want to stick with "-i=mi"
assuming they always use a default. It would be a bad idea
to force them to use explicit options like "-i=mi2".
-- Maxim
2007-08-20 Maxim Grigoriev <maxim2405@gmail.com>
* mi/mi-main.c (mi_load_progress): Make MI and MI2 behave
identically on -target-download command as long as MI2 is a default.
Index: gdb/mi/mi-main.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-main.c,v
retrieving revision 1.101
diff -u -r1.101 mi-main.c
--- gdb/mi/mi-main.c 10 Aug 2007 21:52:38 -0000 1.101
+++ gdb/mi/mi-main.c 20 Aug 2007 20:19:57 -0000
@@ -1465,7 +1465,8 @@
of this function. */
saved_uiout = uiout;
- if (current_interp_named_p (INTERP_MI))
+ if (current_interp_named_p (INTERP_MI)
+ || current_interp_named_p (INTERP_MI2))
uiout = mi_out_new (2);
else if (current_interp_named_p (INTERP_MI1))
uiout = mi_out_new (1);