This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: FW: Re: [patch] mi-cmd-var.c validate type

From: msnyder at sonic dot net
To: gdb-patches at sourceware dot org
Date: Mon, 30 Jul 2007 10:06:08 -0700 (PDT)
Subject: Re: FW: Re: [patch] mi-cmd-var.c validate type
References: <7647.12.7.175.2.1185491461.squirrel@webmail.sonic.net> A<f8dl9a$qra$1@sea.gmane.org> <655C3D4066B7954481633935A40BB36F22BA21@ussunex02.svl.access-company.com>

>>
>> !   return (TYPE_CODE (type) != TYPE_CODE_ARRAY
>> && TYPE_CODE (type) != TYPE_CODE_STRUCT
>> && TYPE_CODE (type) != TYPE_CODE_UNION);
>
> I'd suspect the comment's bogus, in light of this comment in varobj.c
>
>   /* The type of this variable. This may NEVER be NULL. */
>   struct type *type;
>
> I think mi_print_value_p can either assume type is not NULL, or
> gdb_assert that.

OK, how about this?

Attachment: mitype2.txt
Description: Text document

References:
- [patch] mi-cmd-var.c validate type
  - From: msnyder
- Re: [patch] mi-cmd-var.c validate type
  - From: Vladimir Prus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]