This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfc] Remove dead code in breakpoint.c
- From: Markus Deuling <deuling at de dot ibm dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Fri, 22 Jun 2007 11:28:23 +0200
- Subject: [rfc] Remove dead code in breakpoint.c
Hello,
there is no place where DISABLE_UNSETTABLE_BREAK macro is defined. So I guess the code in
breakpoint.c is dead code. But I'm not sure about this- Is there a situation where the removed
code is used? If so please ignore that patch.
ChangeLog:
* breakpoint.c (insert_bp_location): Remove dead code
(DISABLE_UNSETTABLE_BREAK).
(disable_breakpoints_in_shlibs)
(disable_breakpoints_in_unloaded_shlib): Likewise (comment).
Is this ok ?
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
diff -urN src/gdb/breakpoint.c dev/gdb/breakpoint.c
--- src/gdb/breakpoint.c 2007-06-13 20:02:38.000000000 +0200
+++ dev/gdb/breakpoint.c 2007-06-22 10:04:16.000000000 +0200
@@ -963,13 +963,7 @@
if (val)
{
/* Can't set the breakpoint. */
- if (
-#if defined (DISABLE_UNSETTABLE_BREAK)
- DISABLE_UNSETTABLE_BREAK (bpt->address)
-#else
- solib_address (bpt->address)
-#endif
- )
+ if (solib_address (bpt->address))
{
/* See also: disable_breakpoints_in_shlibs. */
val = 0;
@@ -4488,7 +4482,6 @@
struct breakpoint *b;
int disabled_shlib_breaks = 0;
- /* See also: insert_breakpoints, under DISABLE_UNSETTABLE_BREAK. */
ALL_BREAKPOINTS (b)
{
if (((b->type == bp_breakpoint) || (b->type == bp_hardware_breakpoint))
@@ -4524,7 +4517,6 @@
struct breakpoint *b;
int disabled_shlib_breaks = 0;
- /* See also: insert_breakpoints, under DISABLE_UNSETTABLE_BREAK. */
ALL_BREAKPOINTS (b)
{
if ((b->loc->loc_type == bp_loc_hardware_breakpoint