This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: deal thread id as unsigned


On Mon, May 14, 2007 at 12:53:33PM -0400, Daniel Jacobowitz wrote:
> On Tue, Apr 17, 2007 at 11:01:43AM +0900, Yoriko Komatsuzaki wrote:
> > 
> > Thank you for your reply and suggestion.
> > 
> > I get my mind around no modification of defs.h because of the care for other
> > os'es. 
> > 
> > Concerning to thread id printing, I would appreciate it if you could
> > consider to print it by hexadecimal notation.
> 
> Yes, this is a good idea.  Sorry for the delay; I checked in this
> patch, to change the output to hexadecimal.  Tested on x86_64-linux.
> 
> I've just realized that the test change won't work on remote
> debugging; I'll fix up linux-dp.exp.

Like so.  gdbserver reports the LWP ID (PID) as the thread ID, so
decimal is appropriate.

-- 
Daniel Jacobowitz
CodeSourcery

2007-05-14  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.threads/linux-dp.exp: Allow non-hexadecimal IDs also.

Index: testsuite/gdb.threads/linux-dp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
retrieving revision 1.16
diff -u -p -r1.16 linux-dp.exp
--- testsuite/gdb.threads/linux-dp.exp	14 May 2007 16:52:13 -0000	1.16
+++ testsuite/gdb.threads/linux-dp.exp	14 May 2007 16:55:29 -0000
@@ -74,7 +74,7 @@ for {set i 0} {$i < 5} {incr i} {
 	-re "info threads\r\n" {
 	    exp_continue
 	}
-	-re "^. +(\[0-9\]+ Thread 0x\[0-9a-f\]+) \[^\n\]*\n" {
+	-re "^. +(\[0-9\]+ Thread \[-0-9a-fx\]+) \[^\n\]*\n" {
 	    verbose -log "found thread $expect_out(1,string)" 2
 	    lappend threads_before $expect_out(1,string)
 	    exp_continue
@@ -147,7 +147,7 @@ for {set i 0} {$i < 5} {incr i} {
 	-re "info threads\r\n" {
 	    exp_continue
 	}
-	-re "^. +(\[0-9\]+ Thread 0x\[0-9a-f\]+) \[^\n\]*\n" {
+	-re "^. +(\[0-9\]+ Thread \[-0-9a-fx\]+) \[^\n\]*\n" {
 	    set name $expect_out(1,string)
 	    for {set j 0} {$j != [llength $threads_before] } {incr j} {
 		if {$name == [lindex $threads_before $j]} {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]