This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Reduce target_thread_alive calls on GNU/Linux
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: drow at false dot org
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 7 May 2007 09:27:01 +0200 (CEST)
- Subject: Re: [commit] Reduce target_thread_alive calls on GNU/Linux
- References: <20070507004909.GA23607@caradoc.them.org>
> Date: Sun, 6 May 2007 20:49:09 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Index: gdb/linux-thread-db.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-thread-db.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 linux-thread-db.c
> --- gdb/linux-thread-db.c 5 Feb 2007 20:02:51 -0000 1.26
> +++ gdb/linux-thread-db.c 6 May 2007 15:31:41 -0000
> @@ -486,9 +481,9 @@ enable_thread_event_reporting (void)
> td_event_addset (&events, TD_CREATE);
>
> #ifdef HAVE_GNU_LIBC_VERSION_H
> - /* FIXME: kettenis/2000-04-23: The event reporting facility is
> - broken for TD_DEATH events in glibc 2.1.3, so don't enable it for
> - now. */
> + /* The event reporting facility is broken for TD_DEATH events in
> + glibc 2.1.3, so don't enable it we have glibc but a lower
> + version. */
> libc_version = gnu_get_libc_version ();
> if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2
> && (libc_major > 2 || (libc_major == 2 && libc_minor > 1)))
I think there is a missing "if" in that comment.
Mark