This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips-tdep.c: Style fixes


On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:

> > -	      int partial_len = (len < mips_abi_regsize (gdbarch)
> > -				 ? len : mips_abi_regsize (gdbarch));
> > +	      int partial_len = (len < mips_abi_regsize (gdbarch))
> > +				? len : mips_abi_regsize (gdbarch);
> 
> These (and most of the others) were actually there for a reason.
> Emacs will move that second line leftwards if there isn't an outer
> layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.

 I can revert these, no problem -- it just looks strange and is not useful 
from the language's point of view to have the right-hand side of an 
assignment in brackets.  OTOH, this qualifies as a workaround for what 
should probably be considered a bug in the respective tools, so perhaps 
those should be fixed instead?

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]