This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: dj at redhat dot com, gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
- Date: Mon, 2 Apr 2007 00:02:28 -0700
- Subject: Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems
- References: <20070328191845.GB3956@adacore.com> <200703281930.l2SJUYLW003949@greed.delorie.com> <20070328193743.GC3956@adacore.com> <20070328202443.GD3956@adacore.com> <ubqi97hiq.fsf@gnu.org>
> Sorry for chiming in only now, but I have a few minor comments:
Not a problem at all, Eli. I am not able to followup on them right
now, but I promise I will in a few days.
> > for (;;)
> > {
> > int c1 = tolower (*s1);
> > int c2 = tolower (*s2);
>
> Are we sure that strncasecmp's behavior wrt to locales is identical to
> that of tolower's? If not, the above will introduce a bug in
> non-English locales.
For this question, I'm not sure, actually.
--
Joel