This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Signed vs. unsigned adresses in solib-svr4
- From: Andreas Schwab <schwab at suse dot de>
- To: gdb-patches at sourceware dot org
- Date: Tue, 27 Mar 2007 21:16:28 +0200
- Subject: Signed vs. unsigned adresses in solib-svr4
All but two places in solib-svr4.c assume unsigned target addresses. This
patch fixes these two occurences of extract_signed_integer to make things
consistent.
Andreas.
2007-03-27 Andreas Schwab <schwab@suse.de>
* solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use
extract_unsigned_integer instead of extract_signed_integer.
(LM_DYNAMIC_FROM_LINK_MAP): Likewise.
Index: solib-svr4.c
===================================================================
RCS file: /cvs/src/src/gdb/solib-svr4.c,v
retrieving revision 1.61
diff -u -a -p -u -p -a -r1.61 solib-svr4.c
--- solib-svr4.c 9 Jan 2007 17:58:58 -0000 1.61
+++ solib-svr4.c 27 Mar 2007 19:12:52 -0000
@@ -138,9 +138,9 @@ LM_ADDR_FROM_LINK_MAP (struct so_list *s
{
struct link_map_offsets *lmo = svr4_fetch_link_map_offsets ();
- return (CORE_ADDR) extract_signed_integer (so->lm_info->lm
- + lmo->l_addr_offset,
- lmo->l_addr_size);
+ return (CORE_ADDR) extract_unsigned_integer (so->lm_info->lm
+ + lmo->l_addr_offset,
+ lmo->l_addr_size);
}
static int
@@ -158,9 +158,9 @@ LM_DYNAMIC_FROM_LINK_MAP (struct so_list
gdb_assert (lmo->l_ld_size != 0);
- return (CORE_ADDR) extract_signed_integer (so->lm_info->lm
- + lmo->l_ld_offset,
- lmo->l_ld_size);
+ return (CORE_ADDR) extract_unsigned_integer (so->lm_info->lm
+ + lmo->l_ld_offset,
+ lmo->l_ld_size);
}
static CORE_ADDR
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."