This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Little Cleanup

> Date: Tue, 6 Mar 2007 11:52:11 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: Jim Blandy <jimb@codesourcery.com>, mark.kettenis@xs4all.nl,
> 	deuling@de.ibm.com, pedro_alves@portugalmail.pt,
> 	gdb-patches@sourceware.org
> 
> Then perhaps this suggests that the function could be renamed into
> something clearer?

Fine with me.  Note that the original code had a local variable that
made this clear; this whole discussion was caused by a patch that
removed that variable.

> But otherwise, yes, I agree with Jim and Mark,
> because maintaining these comments everywhere is going to be an issue.

I never said anything about ``maintaining these comments everywhere''.
There's no need for such generalizations.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]