This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch/OSX host]: avoid `format not a string literal and no format arguments'
- From: Daniel Jacobowitz <drow at false dot org>
- To: Masaki Muranaka <monaka at monami-software dot com>
- Cc: gdb-patches at sourceware dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Feb 2007 11:59:29 -0500
- Subject: Re: [patch/OSX host]: avoid `format not a string literal and no format arguments'
- References: <82182199-69A4-4141-8F99-6EF89E635476@monami-software.com>
Does any GCC maintainer have an opinion on this patch? It seems
sensible to me.
On Mon, Feb 12, 2007 at 01:50:12PM +0900, Masaki Muranaka wrote:
> Hello Maintainers,
>
> The attachment is to enable build CVS head of GDB on OSX host.
> This is caused by similar issue that had discussed at
> gdb-patches on Jun 2006.
>
> It might be better that it is fixed other externs also.
>
> - - - - - - -
> 2007-02-12 Masaki Muranaka <monaka@monami-software.com>
>
> * libgnuintl.h: Add attribute for format_arg to gettext().
>
> --
> Masaki Muranaka
> Monami software
>
> Index: libgnuintl.h
> ===================================================================
> RCS file: /cvs/src/src/intl/libgnuintl.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 libgnuintl.h
> --- libgnuintl.h 22 May 2006 15:30:13 -0000 1.1
> +++ libgnuintl.h 12 Feb 2007 04:34:55 -0000
> @@ -125,7 +125,7 @@ static inline char *gettext (const char
> #ifdef _INTL_REDIRECT_MACROS
> # define gettext libintl_gettext
> #endif
> -extern char *gettext _INTL_PARAMS ((const char *__msgid))
> +extern char *gettext _INTL_PARAMS ((const char *__msgid)) __attribute__((format_arg(1)))
> _INTL_ASM (libintl_gettext);
> #endif
>
>
--
Daniel Jacobowitz
CodeSourcery