This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Add support for catch Ada exceptions (take 2)
On Tue, Jan 02, 2007 at 10:15:26AM +0400, Joel Brobecker wrote:
> Apart from that, I'm pretty happy the way the exercise turned out.
Me too. This is OK with just two things: I mentioned xstrprintf to
avoid duplicating strings in another message around when you posted
this, and some calls to error don't use _().
The bits in is_known_support_routine are definitely improvable.
It seems that I should have added some sort of baton to the
breakpoint_ops; that would save you a bunch of stub functions.
If you think that's a good idea, feel free to give it a try :-)
But no need.
> (exception_catchpoint_kind): New enum.
> (function_name_from_pc): New function.
> (is_known_support_routine): New function.
> (ada_find_printable_frame): New function.
You can probably cut this to half the length if you put two functions
on each line:
(exception_catchpoint_kind, function_name_from_pc)
(is_known_support_routine, ada_find_printable_frame): New.
[Except for all of them.]
> NEWS entry and documentation will follow shortly after approval.
Yes please :-)
--
Daniel Jacobowitz
CodeSourcery