This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
- From: Andreas Schwab <schwab at suse dot de>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Tue, 02 Jan 2007 14:26:49 +0100
- Subject: Re: [RFC/RFA] Add support for catch Ada exceptions (take 2)
- References: <20061231060649.GF25236@adacore.com> <uwt47afr4.fsf@gnu.org> <20070102054523.GF17211@adacore.com>
Joel Brobecker <brobecker@adacore.com> writes:
>> > + switch (b->type)
>> > + {
>> > + case bp_catch_exception:
>> > + if (b->addr_string != NULL)
>> > + {
>> > + const char *template = _("`%s' Ada exception");
>> > + char *msg = alloca (strlen (template) + strlen (b->addr_string));
>> > +
>> > + sprintf (msg, _("`%s' Ada exception"), b->addr_string);
>>
>> Why don't you use `template' instead of having two identical strings?
>
> That's what I first did, but the compiler complains that he cannot check
> the string format.
If you use static const char[] instead then the compiler is able to do the
checks.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."