This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI: fix base members in references
- From: Vladimir Prus <ghost at cs dot msu dot su>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 08 Dec 2006 15:52:33 +0300
- Subject: Re: MI: fix base members in references
- References: <200611291555.42209.ghost@cs.msu.su> <17783.60807.26167.746362@kahikatea.snap.net.nz>
Nick Roberts wrote:
> > I guess we need to
> > first
> > commit the primary references patch and then fix c_number_of_children.
> > Not that I find references to pointers very common thing, but better be
> > correct.
>
> The patch below seems to fix it for me. Its a diff on 1.63 _with_ your
> yet to be committed changes.
I would have preferred if instead of adding if, the code was modified to
look at
value_type (var->value)
as opposed to
var->type
The latter is the type of the varobj expression as it is in source program.
The former is the value we're actually showing. It makes sense to use
value_type (var->value) for all presentation purposes.
>
> Since we have been the only two people directly contributing to for a
> while now MI, and as it would stop the patches piling up, perhaps Vladimir
> (if
> interested)
I don't very well understand maintainership structure in gdb, but I would
surely appreciate a permission to commit MI patches directly.
- Volodya