This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: remove redundant code in ada-lang.c


Joel Brobecker <brobecker@adacore.com> writes:
>> I don't have an Ada compiler handy, so I can't test this, but does
>> this look right, Joel?  It seems to me that since
>> ada_value_primitive_packed_val is passed arr as its 'obj' parameter,
>> v's lvalue type should already be set accordingly.
>> 
>> 2006-11-22  Jim Blandy  <jimb@codesourcery.com>
>> 
>> 	* ada-lang.c (value_subscript_packed): Don't bother to set the
>> 	lvalue type of the returned value here;
>> 	ada_value_primitive_packed_val takes care of that.
>
> Paul Hilfinger reviewed the patch for us and said that it looked good.
> I tested it on my laptop and showed no regression.

Committed --- thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]