This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

mi_cmd_var_create cleanups


The mi_cmd_var_create seem to use cleanups in non-standard way. That does not 
cause any apparent problem, but still better fixed. Is the attached OK?

Tested on x86, no regressions.

- Volodya

	* mi/mi-cmd-var.c (mI_cmd_var_create): Fix cleanup
	handlers. Free expression.


? .gdbinit
? 00ALL.diff
? 00FROZEN
? 00FROZEN.diff
? 00FROZEN.txt
? 00IMPROVE_LAZINESS.diff
? 00LAZINESS
? 00LAZYNESS.diff
? 00MEMCHECK.diff
? 00MEMECHECK
? 00VAROBJ.diff
? 01ALL.diff
? 01FROZEN_LAST.diff
? A.diff
? ARM.diff
? AUTO_HARDWARE.diff
? B.diff
? Makefile
? ada-exp.c
? ada-lex.c
? auto-hw__gdb_mainline.diff
? breakpoint.diff
? breakpoint.orig.c
? c-exp.c
? config.cache
? config.h
? config.log
? config.status
? cp-name-parser.c
? f-exp.c
? flash_breakpoints.diff
? gdb
? gdb_real
? gdb_stdint.h
? gdbtui
? hardware_breakpoint.diff
? help.diff
? init.c
? jv-exp.c
? log.bz2
? m2-exp.c
? memcheck.diff
? memcheck__gdb_mainline.diff
? memcheck_committed.diff
? mi_cmd_var_create.diff
? objc-exp.c
? observer.h
? observer.inc
? p-exp.c
? serial.diff
? stamp-h
? tmp
? varobj.original.c
? version.c
? cli/a.c
? cli/help.diff
? cli/show_class.diff
? doc/GDBvn.texi
? doc/Makefile
? doc/annotate.info
? doc/config.log
? doc/config.status
? doc/gdb.info
? doc/gdb.info-1
? doc/gdb.info-2
? doc/gdb.info-3
? doc/gdb.info-4
? doc/gdbint.info
? doc/gdbint.info-1
? doc/gdbint.info-2
? doc/stabs.info
? doc/tmp
? gdbserver/Makefile
? gdbserver/config.h
? gdbserver/config.log
? gdbserver/config.status
? gdbserver/gdbreplay
? gdbserver/gdbserver
? gdbserver/reg-i386-linux.c
? gdbserver/stamp-h
? gdbserver/version.c
? testsuite/.gdb_history
? testsuite/00HELP
? testsuite/HELP2.diff
? testsuite/Makefile
? testsuite/bigcore.corefile
? testsuite/config.log
? testsuite/config.status
? testsuite/copy1.txt
? testsuite/foobar.baz
? testsuite/gdb.7824
? testsuite/gdb.8189
? testsuite/gdb.8217
? testsuite/gdb.8229
? testsuite/gdb.8249
? testsuite/gdb.8268
? testsuite/gdb.8279
? testsuite/gdb.8302
? testsuite/gdb.8321
? testsuite/gdb.8340
? testsuite/gdb.8359
? testsuite/gdb.8376
? testsuite/gdb.8392
? testsuite/gdb.8411
? testsuite/gdb.8433
? testsuite/gdb.8452
? testsuite/gdb.8471
? testsuite/gdb.8488
? testsuite/gdb.8498
? testsuite/gdb.8531
? testsuite/gdb.8553
? testsuite/gdb.8571
? testsuite/gdb.8592
? testsuite/gdb.8664
? testsuite/gdb.8676
? testsuite/gdb.8695
? testsuite/gdb.8715
? testsuite/gdb.8734
? testsuite/gdb.8756
? testsuite/gdb.8849
? testsuite/gdb.8877
? testsuite/gdb.8885
? testsuite/gdb.8936
? testsuite/gdb.8968
? testsuite/gdb.8989
? testsuite/gdb.9009
? testsuite/gdb.9028
? testsuite/gdb.9176
? testsuite/gdb.9209
? testsuite/gdb.9228
? testsuite/gdb.9259
? testsuite/gdb.9315
? testsuite/gdb.9358
? testsuite/gdb.9389
? testsuite/gdb.9409
? testsuite/gdb.9437
? testsuite/gdb.9462
? testsuite/gdb.9481
? testsuite/gdb.9517
? testsuite/gdb.9537
? testsuite/gdb.9592
? testsuite/gdb.9635
? testsuite/gdb.9663
? testsuite/gdb.9671
? testsuite/gdb.9703
? testsuite/gdb.9722
? testsuite/gdb.9738
? testsuite/gdb.9758
? testsuite/gdb.9777
? testsuite/gdb.9856
? testsuite/gdb.9875
? testsuite/gdb.9900
? testsuite/gdb.9921
? testsuite/gdb.log
? testsuite/gdb.new.log
? testsuite/gdb.new.sum
? testsuite/gdb.original.log
? testsuite/gdb.original.sum
? testsuite/gdb.sum
? testsuite/help.diff
? testsuite/site.exp
? testsuite/tracecommandsscript
? testsuite/weird.diff
? testsuite/gdb.ada/Makefile
? testsuite/gdb.arch/Makefile
? testsuite/gdb.arch/i386-prologue
? testsuite/gdb.arch/i386-size
? testsuite/gdb.arch/i386-sse
? testsuite/gdb.arch/i386-unwind
? testsuite/gdb.asm/Makefile
? testsuite/gdb.asm/asm-source
? testsuite/gdb.base/.debug
? testsuite/gdb.base/Makefile
? testsuite/gdb.base/advance
? testsuite/gdb.base/all-types
? testsuite/gdb.base/annota1
? testsuite/gdb.base/annota3
? testsuite/gdb.base/args
? testsuite/gdb.base/arrayidx
? testsuite/gdb.base/async
? testsuite/gdb.base/attach
? testsuite/gdb.base/attach2
? testsuite/gdb.base/auxv
? testsuite/gdb.base/auxv.gcore
? testsuite/gdb.base/bang!
? testsuite/gdb.base/bfp-test
? testsuite/gdb.base/bigcore
? testsuite/gdb.base/bigcore.corefile
? testsuite/gdb.base/bitfields
? testsuite/gdb.base/bitfields2
? testsuite/gdb.base/break
? testsuite/gdb.base/breako2
? testsuite/gdb.base/call-ar-st
? testsuite/gdb.base/call-rt-st
? testsuite/gdb.base/call-sc-tc
? testsuite/gdb.base/call-sc-td
? testsuite/gdb.base/call-sc-te
? testsuite/gdb.base/call-sc-tf
? testsuite/gdb.base/call-sc-ti
? testsuite/gdb.base/call-sc-tl
? testsuite/gdb.base/call-sc-tld
? testsuite/gdb.base/call-sc-tll
? testsuite/gdb.base/call-sc-ts
? testsuite/gdb.base/call-strs
? testsuite/gdb.base/callfuncs
? testsuite/gdb.base/charset
? testsuite/gdb.base/checkpoint
? testsuite/gdb.base/chng-syms
? testsuite/gdb.base/commands
? testsuite/gdb.base/complex
? testsuite/gdb.base/consecutive
? testsuite/gdb.base/constvars
? testsuite/gdb.base/corefile
? testsuite/gdb.base/coremaker
? testsuite/gdb.base/cursal
? testsuite/gdb.base/cvexpr
? testsuite/gdb.base/dbx-test
? testsuite/gdb.base/del
? testsuite/gdb.base/display
? testsuite/gdb.base/dump
? testsuite/gdb.base/ending-run
? testsuite/gdb.base/execd-prog
? testsuite/gdb.base/exprs
? testsuite/gdb.base/fileio
? testsuite/gdb.base/foll-exec
? testsuite/gdb.base/foll-fork
? testsuite/gdb.base/foll-vfork
? testsuite/gdb.base/freebpcmd
? testsuite/gdb.base/funcargs
? testsuite/gdb.base/gcore
? testsuite/gdb.base/gcore.test
? testsuite/gdb.base/gdb1090
? testsuite/gdb.base/gdb1250
? testsuite/gdb.base/gdb1555-main
? testsuite/gdb.base/gdb1821
? testsuite/gdb.base/help.diff
? testsuite/gdb.base/help.my.exp
? testsuite/gdb.base/huge
? testsuite/gdb.base/int-type
? testsuite/gdb.base/interrupt
? testsuite/gdb.base/jump
? testsuite/gdb.base/langs
? testsuite/gdb.base/lineinc
? testsuite/gdb.base/list
? testsuite/gdb.base/long_long
? testsuite/gdb.base/macscp
? testsuite/gdb.base/mips_pro
? testsuite/gdb.base/miscexprs
? testsuite/gdb.base/multi-forks
? testsuite/gdb.base/nodebug
? testsuite/gdb.base/opaque
? testsuite/gdb.base/pc-fp
? testsuite/gdb.base/pending
? testsuite/gdb.base/pendshr.sl
? testsuite/gdb.base/pointers
? testsuite/gdb.base/printcmds
? testsuite/gdb.base/psymtab
? testsuite/gdb.base/ptr-typedef
? testsuite/gdb.base/ptype
? testsuite/gdb.base/recurse
? testsuite/gdb.base/reread
? testsuite/gdb.base/reread1
? testsuite/gdb.base/restore
? testsuite/gdb.base/return
? testsuite/gdb.base/return2
? testsuite/gdb.base/run
? testsuite/gdb.base/savedregs
? testsuite/gdb.base/scope
? testsuite/gdb.base/sep
? testsuite/gdb.base/sepdebug
? testsuite/gdb.base/sepdebug.debug
? testsuite/gdb.base/sepdebug.stripped
? testsuite/gdb.base/sepsymtab
? testsuite/gdb.base/sepsymtab.stripped
? testsuite/gdb.base/setshow
? testsuite/gdb.base/setvar
? testsuite/gdb.base/shmain
? testsuite/gdb.base/shr1.sl
? testsuite/gdb.base/shr2.sl
? testsuite/gdb.base/shreloc
? testsuite/gdb.base/shreloc.txt
? testsuite/gdb.base/shreloc1.sl
? testsuite/gdb.base/shreloc2.sl
? testsuite/gdb.base/sigall
? testsuite/gdb.base/sigaltstack
? testsuite/gdb.base/sigbpt
? testsuite/gdb.base/siginfo
? testsuite/gdb.base/signals
? testsuite/gdb.base/signull
? testsuite/gdb.base/sigrepeat
? testsuite/gdb.base/sigstep
? testsuite/gdb.base/sizeof
? testsuite/gdb.base/so-impl-ld
? testsuite/gdb.base/solib1.sl
? testsuite/gdb.base/start
? testsuite/gdb.base/step-bt
? testsuite/gdb.base/step-line
? testsuite/gdb.base/step-test
? testsuite/gdb.base/store
? testsuite/gdb.base/structs-tc
? testsuite/gdb.base/structs-tc-td
? testsuite/gdb.base/structs-tc-tf
? testsuite/gdb.base/structs-tc-ti
? testsuite/gdb.base/structs-tc-tl
? testsuite/gdb.base/structs-tc-tld
? testsuite/gdb.base/structs-tc-tll
? testsuite/gdb.base/structs-tc-ts
? testsuite/gdb.base/structs-td
? testsuite/gdb.base/structs-td-tc
? testsuite/gdb.base/structs-td-tf
? testsuite/gdb.base/structs-tf
? testsuite/gdb.base/structs-tf-tc
? testsuite/gdb.base/structs-tf-td
? testsuite/gdb.base/structs-ti
? testsuite/gdb.base/structs-ti-tc
? testsuite/gdb.base/structs-tl
? testsuite/gdb.base/structs-tl-tc
? testsuite/gdb.base/structs-tld
? testsuite/gdb.base/structs-tld-tc
? testsuite/gdb.base/structs-tll
? testsuite/gdb.base/structs-tll-tc
? testsuite/gdb.base/structs-ts
? testsuite/gdb.base/structs-ts-tc
? testsuite/gdb.base/structs2
? testsuite/gdb.base/twice-tmp
? testsuite/gdb.base/twice-tmp.c
? testsuite/gdb.base/unload
? testsuite/gdb.base/unloadshr.sl
? testsuite/gdb.base/varargs
? testsuite/gdb.base/vforked-prog
? testsuite/gdb.base/watchpoint
? testsuite/gdb.base/whatis
? testsuite/gdb.cp/Makefile
? testsuite/gdb.cp/annota2
? testsuite/gdb.cp/annota3
? testsuite/gdb.cp/anon-union
? testsuite/gdb.cp/bool
? testsuite/gdb.cp/breakpoint
? testsuite/gdb.cp/bs15503
? testsuite/gdb.cp/call-c
? testsuite/gdb.cp/casts
? testsuite/gdb.cp/class2
? testsuite/gdb.cp/classes
? testsuite/gdb.cp/cplusfuncs
? testsuite/gdb.cp/cttiadd
? testsuite/gdb.cp/derivation
? testsuite/gdb.cp/exception
? testsuite/gdb.cp/gdb1355
? testsuite/gdb.cp/hang
? testsuite/gdb.cp/inherit
? testsuite/gdb.cp/local
? testsuite/gdb.cp/m-data
? testsuite/gdb.cp/m-static
? testsuite/gdb.cp/member-ptr
? testsuite/gdb.cp/method
? testsuite/gdb.cp/misc
? testsuite/gdb.cp/namespace
? testsuite/gdb.cp/overload
? testsuite/gdb.cp/ovldbreak
? testsuite/gdb.cp/pr-1023
? testsuite/gdb.cp/pr-1210
? testsuite/gdb.cp/pr-574
? testsuite/gdb.cp/printmethod
? testsuite/gdb.cp/psmang
? testsuite/gdb.cp/ref-params
? testsuite/gdb.cp/ref-types
? testsuite/gdb.cp/rtti
? testsuite/gdb.cp/templates
? testsuite/gdb.cp/try_catch
? testsuite/gdb.cp/userdef
? testsuite/gdb.cp/virtfunc
? testsuite/gdb.disasm/Makefile
? testsuite/gdb.dwarf2/Makefile
? testsuite/gdb.dwarf2/dup-psym.x
? testsuite/gdb.dwarf2/dw2-basic.x
? testsuite/gdb.dwarf2/dw2-intercu.x
? testsuite/gdb.dwarf2/dw2-intermix.x
? testsuite/gdb.dwarf2/mac-fileno.x
? testsuite/gdb.fortran/Makefile
? testsuite/gdb.java/Makefile
? testsuite/gdb.mi/Makefile
? testsuite/gdb.mi/basics
? testsuite/gdb.mi/gdb669-pthreads
? testsuite/gdb.mi/gdb701
? testsuite/gdb.mi/gdb792
? testsuite/gdb.mi/mi-console
? testsuite/gdb.mi/mi-pthreads
? testsuite/gdb.mi/mi-read-memory
? testsuite/gdb.mi/mi-stack
? testsuite/gdb.mi/mi-syn-frame
? testsuite/gdb.mi/mi-var-child
? testsuite/gdb.mi/mi2-pthreads
? testsuite/gdb.mi/until
? testsuite/gdb.mi/var-cmd
? testsuite/gdb.objc/Makefile
? testsuite/gdb.server/Makefile
? testsuite/gdb.server/server
? testsuite/gdb.stabs/Makefile
? testsuite/gdb.stabs/config.log
? testsuite/gdb.stabs/config.status
? testsuite/gdb.stabs/exclfwd
? testsuite/gdb.stabs/weird.diff
? testsuite/gdb.threads/Makefile
? testsuite/gdb.threads/bp_in_thread
? testsuite/gdb.threads/gcore-pthreads
? testsuite/gdb.threads/gcore.test
? testsuite/gdb.threads/killed
? testsuite/gdb.threads/linux-dp
? testsuite/gdb.threads/manythreads
? testsuite/gdb.threads/print-threads
? testsuite/gdb.threads/pthread_cond_wait
? testsuite/gdb.threads/pthreads
? testsuite/gdb.threads/schedlock
? testsuite/gdb.threads/staticthreads
? testsuite/gdb.threads/switch-threads
? testsuite/gdb.threads/thread-specific
? testsuite/gdb.threads/thread_check
? testsuite/gdb.threads/threadapply
? testsuite/gdb.threads/tls
? testsuite/gdb.threads/tls-main
? testsuite/gdb.threads/tls-nodebug
? testsuite/gdb.threads/watchthreads
? testsuite/gdb.trace/Makefile
? testsuite/gdb.trace/actions
? testsuite/gdb.trace/circ
? testsuite/gdb.trace/collection
? testsuite/gdb.trace/limits
Index: mi/mi-cmd-var.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-cmd-var.c,v
retrieving revision 1.23
diff -u -p -r1.23 mi-cmd-var.c
--- mi/mi-cmd-var.c	23 Dec 2005 18:57:46 -0000	1.23
+++ mi/mi-cmd-var.c	28 Nov 2006 19:17:46 -0000
@@ -66,9 +66,10 @@ mi_cmd_var_create (char *command, char *
   old_cleanups = make_cleanup (free_current_contents, &name);
 
   frame = xstrdup (argv[1]);
-  old_cleanups = make_cleanup (xfree, frame);
+  make_cleanup (xfree, frame);
 
   expr = xstrdup (argv[2]);
+  make_cleanup (xfree, expr);
 
   if (strcmp (name, "-") == 0)
     {

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]