This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Patch: Little improvement to delete breakpoint command
- From: Daniel Jacobowitz <drow at false dot org>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Tue, 28 Nov 2006 12:24:58 -0500
- Subject: Re: Patch: Little improvement to delete breakpoint command
- References: <456C7023.4050204@de.ibm.com>
On Tue, Nov 28, 2006 at 06:21:39PM +0100, Markus Deuling wrote:
> Hello,
>
> this little patch adds a break to the loop that is looking for
> breakpoints to delete in delete_command(). I think it is only necessary
> to find one breakpoint, there is no need to iterate further if found one.
>
> ===================================================================
> --- breakpoint.old 2006-11-28 17:08:11.000000000 +0100
> +++ breakpoint.c 2006-11-28 17:42:15.000000000 +0100
> @@ -6960,6 +6960,7 @@
> b->type != bp_overlay_event &&
> b->number >= 0)
> breaks_to_delete = 1;
> + break;
> }
>
> /* Ask user only if there are some breakpoints to delete. */
>
Did you test this? I'm pretty sure you're missing braces.
--
Daniel Jacobowitz
CodeSourcery