This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove REALTIME_HI/LO macros from target headers
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 28 Nov 2006 10:28:57 -0500
- Subject: Re: [RFA] Remove REALTIME_HI/LO macros from target headers
- References: <200611242113.kAOLDMdQ032123@d12av02.megacenter.de.ibm.com>
On Fri, Nov 24, 2006 at 10:13:22PM +0100, Ulrich Weigand wrote:
> However, since signals.c appears to be used only in native configurations,
> that doesn't actually matter. On the other hand, this means we can get
> those defines out of the tm-*.h files and into the nm-*.h files.
Well, those two routines anyway - some of the others are used in common
code.
> The following files currently define the REALTIME macros:
> - config/tm-linux.h and config/mips/tm-linux.h
> - config/rs6000/tm-rs6000ly.h
> - config/tm-nto.h
>
> For Linux, the nm-linux.h file already defines those macros, so the
> definitions in the tm files appear to be fully redundant.
The nm-linux.h define is redundant too, isn't it? And off by one?
Compare to the top of signals.c. Or is the copy in signals.c off by
one?
Patch looks OK modulo that question.
--
Daniel Jacobowitz
CodeSourcery