This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Do not make up line information
Daniel Jacobowitz <drow@false.org> writes:
> On Wed, Nov 22, 2006 at 11:54:13AM -0800, Jim Blandy wrote:
>> Wow --- that's weird code. Where did that alt->line - 1 come from?
>>
>> If we can't find the original motivation, the change looks like an
>> obvious improvement to me.
>
> It predates all our changelogs. I imagine it predates debug info for
> inlining, and DWARF-2, too.
It seems to me that, when one can't find the rationale for something
weird after a responsible look, it's best to just replace it with
something reasonable and see what happens. Otherwise, the overall
dynamic is for things to become choked with obscure bits that nobody
can test alternatives to.
So I'd say, commit it.