This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Readline bug causes GDB crash on 64-bit


Daniel Jacobowitz wrote:
> On Fri, Oct 20, 2006 at 11:10:43PM +0200, Ulrich Weigand wrote:
>> Hello,
>>
>> GDB on s390x (64-bit) is crashing when you press ctrl-V.
>> This is because xmalloc is used without prototype in scope
>> in _rl_callback_data_alloc (readline/callback.c), and thus
>> the returned pointer is improperly truncated/extended.
>>
>> Fixed by including "xmalloc.h".  Tested on s390x-ibm-linux.
>>
>> What's the policy for readline bugs in GDB?  It is OK to check
>> this patch into GDB, or does it have to go upstream first?
>> (Where is readline upstream?)
> 
> The right thing to do is to send the patch to Chet, and if he accepts
> it for the next readline release, commit it to our copy.  I believe
> bash-maintainers@gnu.org (CC'd) is the right place.

Either that address or bug-readline@gnu.org will work.  But in this
case, someone beat you to it, and the fix is in the recently-released
readline-5.2.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		       Live Strong.  No day but today.
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]