This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: copy-edit File-I/O section of manual


> Date: Sat, 13 May 2006 10:29:33 -0400
> From: Sandra Loosemore <sandra@codesourcery.com>
> 
> When I was implementing the File-I/O protocol recently, I noticed a lot of 
> spelling and grammatical mistakes in that section of the manual.  Here's a patch 
> to clean it up.

Thanks.  However, could you please submit these as two separate
patches, one that fixes only the spelling and grammar, the other with
the rest?  I'd like to understand the motivation for moving stuff
around, for starters.

Also, when you send the patch for spelling and grammar, please try not
to reformat lines, so that unmodified lines don't appear in the diffs.
The way you did it (refilling the paragraphs after changing them)
makes the diffs unnecessarily voluminous and hard to read.

TIA

> 2006-05-13  Sandra Loosemore  <sandra@codesourcery.com>
> 	* gdb.texinfo (File-I/O remote protocol extension): General
> 	copy-editing to fix spelling, grammar, formatting issues.
> 	Moved a few paragraphs around to more logical places.

The ChangeLog entries should mention the node name for each change; it
is not sufficient to name only their parent node.

> ! The File-I/O protocol uses the @code{F} packet as the request as well
>   as as reply packet.
    ^^^^^
This is still not right.

Thanks again for working on this.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]