This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa] Shared object matching for solib-som.c
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Randolph Chung <randolph at tausq dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 19 Apr 2006 12:07:16 +0300
- Subject: Re: [rfa] Shared object matching for solib-som.c
- References: <44458D3D.4030506@tausq.org> <u8xq2x9pj.fsf@gnu.org> <4445F4D5.1030302@tausq.org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 19 Apr 2006 16:29:09 +0800
> From: Randolph Chung <randolph@tausq.org>
> CC: gdb-patches@sources.redhat.com
>
> > Please don't use literal slash characters in GDB sources: they are
> > non-portable. AFAICS, you simply need to use lbasename here, on both
> > file names.
>
> I guess you mean "basename" instead of "lbasename".
No, I mean lbasename, the one from libiberty. That solves a problem
of basename being not portable enough (I think we never use basename
in GDB, only lbasename, but I might be wrong).
> While I agree with your portability comment, I hope nobody is crazy
> enough to use SOM outside of hpux :)
Probably not, but people frequently lift code by copy/paste. Anyway,
these are our coding standards, AFAIK.
> Anyway, I'll redo this using basename.
Thanks, but please use lbasename.