This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch-readline] history file reading
Daniel Jacobowitz <drow@false.org> writes:
>> + if ( line_end - 1 >= line_start && *( line_end - 1 ) =='\r' )
>> + *( line_end - 1 ) = '\0';
>
> And you don't need the spaces inside the parentheses, but do usually
> need spaces around operators:
>
> if (line_end - 1 >= line_start && *(line_end - 1) == '\r')
> *(line_end - 1) = '\0';
line_end[-1] whould be much better readable, IMHO.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."