This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units


On Thu, Feb 16, 2006 at 07:16:00PM -0500, Fred Fish wrote:
> On Tuesday 14 February 2006 09:10, Daniel Jacobowitz wrote:
> > This patch seems OK to me; but we really ought to fix up the comment
> > directly above this code that you're changing.
> 
> I've think it would be best to split work on this issue up into two parts
> 
> (1) Make ptype and whatis handle the same arguments.  Currently ptype
> will work on typedefs, but whatis does not.  This is the change that
> makes them both use whatis_exp and eliminates ptype_eval.
> 
> (2) Make ptype and whatis handle printing types specified in a given
> context using 'file'::type.  I have a fix that involves a fairly
> minor change to the parser and makes the patch you are commenting on
> obsolete.
> 
> Here is the patch for (1).  I believe we previously reached on consensus
> that this change was OK, so I'd like to get it checked in.  I added some
> testsuite support for testing how whatis behaves with typedef names.

I didn't see any followups to this except for the docs, but I've got no
objection, so it's just as well you've checked it in :-)


-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]