This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Linux Checkpoint/Restart, take 2
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Michael Snyder <michsnyd at cisco dot com>
- Cc: gdb-patches at sources dot redhat dot com, msnyder at redhat dot com
- Date: Tue, 20 Dec 2005 22:50:22 +0200
- Subject: Re: [RFA] Linux Checkpoint/Restart, take 2
- References: <43A777EE.50404@cisco.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 19 Dec 2005 19:18:06 -0800
> From: Michael Snyder <michsnyd@cisco.com>
> CC: msnyder@redhat.com
>
> OK, superceding the previous submission, this patch includes
> suggested mods from Eli and Tom Tromey. Fixed comment formatting,
> tweaked documentation, added NEWS and gdbint.texinfo.
Thanks! The documentation patches can go in, provided that you take
care of the minor issues mentioned below.
> + @var{checkpoint-id}. All program variables, registers, stack frames
> + etc. will be returned to the values that they had when the checkpoint
Need a "@:" after "etc.", since it doesn't end a sentence. For the
same reason, there need to be only one space after it, not two.
> + It won't ``un-write'' data from
> + a file, but it will rewind the file pointer to the previous location,
Really? isn't the file pointer stored inside some OS kernel data
structure?
> + from eg. a serial device can be removed from internal program buffers,
Pleased add "@:" after "eg." (actually, I believe we need to say
"e.g.").
> + in gdb, eg. as corefiles, as forked processes, and as some opaque
Same here.
> + Some targets, eg. simulators, might have their own built-in
And here.
Thanks again for adding this great feature and for your efforts in
providing good documentation.