This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: GDB manual: document tracepoint packets
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jim Blandy <jimb at red-bean dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 20 Nov 2005 00:49:44 +0200
- Subject: Re: RFA: GDB manual: document tracepoint packets
- References: <8f2776cb0511191231y11805c1bqb4b4eb426b0e31fa@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sat, 19 Nov 2005 12:31:20 -0800
> From: Jim Blandy <jimb@red-bean.com>
>
> 2005-11-19 Jim Blandy <jimb@redhat.com>
>
> * gdb.texinfo (Tracepoint Packets): New node.
> (General Query Packets): Add entries for the tracepoint packets,
> referring to the "Tracepoint Packets" node.
Thanks. My comments are below.
> + @node Tracepoint Packets
> + @section Tracepoint Packets
Suggest a @cindex entry here, something like "tracepoint packets".
> + Here we describe the packets @value{GDBN} uses to implement
> + tracepoints (@pxref{Tracepoints}).
I think it would be good to have an @xref from the "Tracepoints" node
to here as well.
> + Replies:
> + @table @samp
> + @item OK
> + The packet was understood and carried out.
> + @item
Does this @item really need to be empty? If so, why, and what do we
want to appear here in print?
> + @item
> + The packet was not recognized.
Same here.
> + A successful reply from the stub and indicates that the stub has found
^^^
That "and" seems extraneous.
Other than that, this can go in. Thanks again for working on this.