This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] Support DW_OP_breg for tracepoints

On Mon, Nov 14, 2005 at 07:48:27AM +0800, Randolph Chung wrote:
> >Why are you adding the offset twice?  Is it just cut-and-paste from
> >the DW_OP_fbreg code?  That looks wrong, too.
> 
> Yes, copy and paste. I don't understand why it's added twice either :) 
> Dan seems to think it's ok, but I'll wait a bit before I commit anything.

I assumed it was right by analogy to the existing frame base code. 
Presumably I was just wrong the first time.  Please fix both places.

Thanks, Jim.

> >This code should go in ax-gdb.[ch].  That has a translator from GDB
> >expressions to agent expressions; it would make sense to also have a
> >translator from Dwarf expressions to agent expressions.

Why is it any more logical to have dwarf code in ax-gdb.c than to have
agent code in dwarf2loc.c?  In any case, it is a method of the symbol.
Please see struct symbol_ops.

-- 
Daniel Jacobowitz
CodeSourcery, LLC
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]