This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] VAX floating point support
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: gdb-patches at sourceware dot org
- Date: Tue, 1 Nov 2005 00:35:55 +0100 (CET)
- Subject: [commit] VAX floating point support
Now that the -liberty bits are in, this can finally go in. No more
core dumps if you try to print a floating-point number on VAX :).
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* doublest.c (floatformat_normalize_byteorder): Handle
floatformat_vax.
(convert_doublest_to_floatformat): Use
floatformat_normalize_byteorder to swap bytes if necessary.
* vax-tdep.c: Include floatformat.h.
(vax_gdbarch_init): Set float_format, double_format,
long_double_format and long_double_bit.
* Makefile.in (vax-tdep.o): Update dependencies.
Index: doublest.c
===================================================================
RCS file: /cvs/src/src/gdb/doublest.c,v
retrieving revision 1.26
diff -u -p -r1.26 doublest.c
--- doublest.c 21 Aug 2005 16:53:05 -0000 1.26
+++ doublest.c 31 Oct 2005 23:34:55 -0000
@@ -1,8 +1,8 @@
/* Floating point routines for GDB, the GNU debugger.
Copyright 1986, 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
- 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005 Free Software
- Foundation, Inc.
+ 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005
+ Free Software Foundation, Inc.
This file is part of GDB.
@@ -110,9 +110,10 @@ get_field (const bfd_byte *data, enum fl
return result;
}
-/* Normalize the byte order of FROM into TO. If no normalization is needed
- then FMT->byteorder is returned and TO is not changed; otherwise the format
- of the normalized form in TO is returned. */
+/* Normalize the byte order of FROM into TO. If no normalization is
+ needed then FMT->byteorder is returned and TO is not changed;
+ otherwise the format of the normalized form in TO is returned. */
+
static enum floatformat_byteorders
floatformat_normalize_byteorder (const struct floatformat *fmt,
const void *from, void *to)
@@ -125,23 +126,40 @@ floatformat_normalize_byteorder (const s
|| fmt->byteorder == floatformat_big)
return fmt->byteorder;
- gdb_assert (fmt->byteorder == floatformat_littlebyte_bigword);
-
words = fmt->totalsize / FLOATFORMAT_CHAR_BIT;
words >>= 2;
swapout = (unsigned char *)to;
swapin = (const unsigned char *)from;
- while (words-- > 0)
+ if (fmt->byteorder == floatformat_vax)
+ {
+ while (words-- > 0)
+ {
+ *swapout++ = swapin[1];
+ *swapout++ = swapin[0];
+ *swapout++ = swapin[3];
+ *swapout++ = swapin[2];
+ swapin += 4;
+ }
+ /* This may look weird, since VAX is little-endian, but it is
+ easier to translate to big-endian than to little-endian. */
+ return floatformat_big;
+ }
+ else
{
- *swapout++ = swapin[3];
- *swapout++ = swapin[2];
- *swapout++ = swapin[1];
- *swapout++ = swapin[0];
- swapin += 4;
+ gdb_assert (fmt->byteorder == floatformat_littlebyte_bigword);
+
+ while (words-- > 0)
+ {
+ *swapout++ = swapin[3];
+ *swapout++ = swapin[2];
+ *swapout++ = swapin[1];
+ *swapout++ = swapin[0];
+ swapin += 4;
+ }
+ return floatformat_big;
}
- return floatformat_big;
}
/* Convert from FMT to a DOUBLEST.
@@ -337,14 +355,13 @@ ldfrexp (long double value, int *eptr)
#endif /* HAVE_LONG_DOUBLE */
-/* The converse: convert the DOUBLEST *FROM to an extended float
- and store where TO points. Neither FROM nor TO have any alignment
+/* The converse: convert the DOUBLEST *FROM to an extended float and
+ store where TO points. Neither FROM nor TO have any alignment
restrictions. */
static void
convert_doublest_to_floatformat (CONST struct floatformat *fmt,
- const DOUBLEST *from,
- void *to)
+ const DOUBLEST *from, void *to)
{
DOUBLEST dfrom;
int exponent;
@@ -353,10 +370,14 @@ convert_doublest_to_floatformat (CONST s
int mant_bits_left;
unsigned char *uto = (unsigned char *) to;
enum floatformat_byteorders order = fmt->byteorder;
+ unsigned char newto[FLOATFORMAT_LARGEST_BYTES];
- if (order == floatformat_littlebyte_bigword)
+ if (order != floatformat_little)
order = floatformat_big;
+ if (order != fmt->byteorder)
+ uto = newto;
+
memcpy (&dfrom, from, sizeof (dfrom));
memset (uto, 0, (fmt->totalsize + FLOATFORMAT_CHAR_BIT - 1)
/ FLOATFORMAT_CHAR_BIT);
@@ -447,24 +468,7 @@ convert_doublest_to_floatformat (CONST s
finalize_byteorder:
/* Do we need to byte-swap the words in the result? */
if (order != fmt->byteorder)
- {
- int words;
- unsigned char *curword = uto;
- unsigned char tmp;
-
- words = fmt->totalsize / FLOATFORMAT_CHAR_BIT;
- words >>= 2;
- while (words-- > 0)
- {
- tmp = curword[0];
- curword[0] = curword[3];
- curword[3] = tmp;
- tmp = curword[1];
- curword[1] = curword[2];
- curword[2] = tmp;
- curword += 4;
- }
- }
+ floatformat_normalize_byteorder (fmt, newto, to);
}
/* Check if VAL (which is assumed to be a floating point number whose
Index: vax-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/vax-tdep.c,v
retrieving revision 1.90
diff -u -p -r1.90 vax-tdep.c
--- vax-tdep.c 12 Jun 2005 11:17:57 -0000 1.90
+++ vax-tdep.c 31 Oct 2005 23:34:55 -0000
@@ -23,6 +23,7 @@
#include "defs.h"
#include "arch-utils.h"
#include "dis-asm.h"
+#include "floatformat.h"
#include "frame.h"
#include "frame-base.h"
#include "frame-unwind.h"
@@ -476,6 +477,11 @@ vax_gdbarch_init (struct gdbarch_info in
gdbarch = gdbarch_alloc (&info, NULL);
+ set_gdbarch_float_format (gdbarch, &floatformat_vax_f);
+ set_gdbarch_double_format (gdbarch, &floatformat_vax_d);
+ set_gdbarch_long_double_format (gdbarch, &floatformat_vax_d);
+ set_gdbarch_long_double_bit(gdbarch, 64);
+
/* Register info */
set_gdbarch_num_regs (gdbarch, VAX_NUM_REGS);
set_gdbarch_register_name (gdbarch, vax_register_name);
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.757
diff -u -p -r1.757 Makefile.in
--- Makefile.in 21 Oct 2005 06:26:27 -0000 1.757
+++ Makefile.in 31 Oct 2005 23:34:58 -0000
@@ -2747,10 +2747,10 @@ vaxnbsd-tdep.o: vaxnbsd-tdep.c $(defs_h)
vaxobsd-tdep.o: vaxobsd-tdep.c $(defs_h) $(arch_utils_h) $(frame_h) \
$(frame_unwind_h) $(osabi_h) $(symtab_h) $(trad_frame_h) \
$(vax_tdep_h) $(gdb_string_h)
-vax-tdep.o: vax-tdep.c $(defs_h) $(arch_utils_h) $(dis_asm_h) $(frame_h) \
- $(frame_base_h) $(frame_unwind_h) $(gdbcore_h) $(gdbtypes_h) \
- $(osabi_h) $(regcache_h) $(regset_h) $(trad_frame_h) $(value_h) \
- $(gdb_string_h) $(vax_tdep_h)
+vax-tdep.o: vax-tdep.c $(defs_h) $(arch_utils_h) $(dis_asm_h) \
+ $(float_format_h)$(frame_h) $(frame_base_h) $(frame_unwind_h) \
+ $(gdbcore_h) $(gdbtypes_h) $(osabi_h) $(regcache_h) $(regset_h) \
+ $(trad_frame_h) $(value_h) $(gdb_string_h) $(vax_tdep_h)
win32-nat.o: win32-nat.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
$(exceptions_h) $(gdbcore_h) $(command_h) $(completer_h) \
$(regcache_h) $(top_h) $(buildsym_h) $(symfile_h) $(objfiles_h) \