Re: MI testsuite to use PTY for inferior

[Daniel Jacobowitz <drow at false dot org>]

On Wed, Aug 03, 2005 at 02:23:51PM -0400, Bob Rossi wrote:
> Sorry, I'm a little trigger happy, here's the patch.

Patch is OK with formatting corrections.

> Index: gdb/testsuite/ChangeLog
> +	* gdb.mi/mi-basics.exp: Tell mi_gdb_start to use a PTY for inferior.
> +	(test_setshow_inferior_tty): Add global mi_inferior_tty_name to scope.
> +	(test_setshow_inferior_tty): Change tests to inferior-tty-set/show.

You shouldn't list the function name twice.

> +	* gdb.mi/mi-console.exp: Tell mi_gdb_start to use a PTY for inferior.
> +	(47-exec-next): Use mi_gdb_test to get GDB and Inferior output.
> +	* gdb.mi/mi-syn-frame.exp: Tell mi_gdb_start to use a PTY for
> +	inferior.
> +	(403-exec-continue): Use mi_gdb_test to get GDB and Inferior output.
> +	(406-data-evaluate-expression have_a_very_merry_interrupt()): Ditto.
> +	(410-data-evaluate-expression bar()): Ditto.
> +	(408-exec-continue): Use mi_gdb_test to get GDB output.

It's fine this way too, but like I think Nick said, you don't need to
mark individual tests in the ChangeLog.  We haven't been bothering and
no one seems to miss it.

> @@ -81,13 +84,17 @@
>  }
>  
>  #
> -# start gdb -- start gdb running, default procedure
> +# start gdb INFERIOR_PTY -- start gdb running, default procedure

Hmm, that doesn't look right.  Did you mean this?

# mi_gdb_start [INFERIOR_PTY] -- start gdb running, default procedure

> +    # create the new pty for the inferior process

# Create the new PTY for the inferior process.


> +    # If allowing the inferior to have it's own PTY then assign the inferior
> +    # it's own terminal device here

# If allowing the inferior to have its own PTY then assign the inferior
# its own terminal device here.

(trailing period, no apostrophe in the possessive "its")

> -# mi_gdb_test COMMAND PATTERN MESSAGE -- send a command to gdb; test the result.
> +# mi_gdb_test COMMAND PATTERN MESSAGE IPATTERN -- send a command to gdb; 
> +#   test the result.

Please say [IPATTERN] to indicate that it's optional.  Yes, I realize
it didn't do this before when MESSAGE was optional.

> +    # if the GDB output matched, compare the inferior output

# If the GDB output matched, compare the inferior output.

-- 
Daniel Jacobowitz
CodeSourcery, LLC