This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: add format attributes to gdb
- From: Eli Zaretskii <eliz at gnu dot org>
- To: "Kaveh R. Ghazi" <ghazi at caipclassic dot rutgers dot edu>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 28 Jul 2005 22:07:14 +0300
- Subject: Re: PATCH: add format attributes to gdb
- References: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 27 Jul 2005 23:10:57 -0400 (EDT)
> From: "Kaveh R. Ghazi" <ghazi@caipclassic.rutgers.edu>
> Cc: ghazi@caipclassic.rutgers.edu
>
> This patch adds format attributes in various places in gdb. I found
> these mainly by compiling gdb using a snapshot of gcc-4.1.x with
> -Wmissing-format-attribute. (GCC 4.1.x has some improvements that
> find more places to add missing format attributes.)
Thanks.
> 2005-07-27 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add
> ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF.
> * complaints.c (vcomplaint): Likewise.
> * defs.h (xvasprintf, xstrvprintf, verror, vfatal,
> internal_verror, internal_vwarning, vwarning,
> deprecated_query_hook, deprecated_warning_hook,
> deprecated_readline_begin_hook): Likewise.
Nitpicking: these multi-line entries are not according to the GNU
coding standards (which specify that each line must end with a right
paren).