Re: [commit] Follow forks on HP-UX 10.20

[Daniel Jacobowitz <drow at false dot org>]

On Tue, Jul 26, 2005 at 12:12:28AM +0200, Mark Kettenis wrote:
> Finally, the goal of this excercise.  The code is also going to be
> used on OpenBSD when I get the necessary kernel stuff committed.  It
> doesn't do follow-vfork yet.  HP-UX 10.20 doesn't really allow you to
> do anything with a vforked child until it execs.  So follow-vfork
> isn't useful until follow-exec is properly implemented.
> 
> Committed,

I'm not really sure this is in the right place.  Good, you're going to
implement the HP/UX ptrace interface on OpenBSD also.  But even then
it'll be HP/UX and OpenBSD specific.  Why can't they inherit from
inf-ptrace.c instead of adding ifdefs to this file?  Isn't that the
point of target inheritance - to avoid having code in the "base
classes" which is only useful on a few targets?

> P.S. Daniel, I'm going to remove the messages from inf-ttrace.c such
> that things behaves the same way on HP-UX 11.xx as they do on HP-UX
> 10.20.

Sounds good.

> @@ -471,6 +588,9 @@ inf_ptrace_target (void)
>    t->to_files_info = inf_ptrace_files_info;
>    t->to_kill = inf_ptrace_kill;
>    t->to_create_inferior = inf_ptrace_create_inferior;
> +#ifdef PT_GET_PROCESS_STATE
> +  t->to_follow_fork = inf_ptrace_follow_fork;
> +#endif
>    t->to_mourn_inferior = inf_ptrace_mourn_inferior;
>    t->to_thread_alive = inf_ptrace_thread_alive;
>    t->to_pid_to_str = normal_pid_to_str;

This in particular makes me think it's in the wrong place.

-- 
Daniel Jacobowitz
CodeSourcery, LLC