This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] i386-tdep.c: Fix datatype
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 23 Jun 2005 22:54:32 +0200 (CEST)
- Subject: Re: [RFA] i386-tdep.c: Fix datatype
- References: <20050623163637.GS2814@calimero.vinschen.de>
Date: Thu, 23 Jun 2005 18:36:37 +0200
From: Corinna Vinschen <vinschen@redhat.com>
Hi,
the below patch is just a minor tweak. The stack pointer offset sp_offset
stored in struct i386_frame_cache is an offset, not an address. It looks
more correct to define it as LONGEST, not as CORE_ADDR. Especially since
sp_offset can contain positve and negative values.
Corinna
* i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
Aauming this compiles with -Werror (and I have no reason to suspect
that it wouldn't, this is ok.
Thanks,
Mark