This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MI error messages


On Wed, Jun 22, 2005 at 09:44:17AM +1200, Nick Roberts wrote:
> Eli Zaretskii writes:
>  > > Which file should mi_error/mi_usage_error go in?  mi-cmds.c seems the best
>  > > option to me as the mi-cmd-*.c files include mi-cmds.h.
>  > 
>  > I don't care much, but isn't mi-common.c a better place?
> 
> mi-common.c seems a bit of a misnomer.  Perhap common here means frequent
> rather than shared.  mi-common.h isn't included in any of the c files apart
> from mi-common.c

Well, I just added mi-common. It was intended to be an interface for the
rest of GDB to be able to get constant string data or MI specific
enumeration values from the MI code. 

It could also be used for common data for the MI internals itself, but I
would probably advice against that. It might be nice to add another file
that allows the internals of the MI code to share data and such.

Bob Rossi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]