Re: [PATCH] -data-list-changed-registers (Take 2)

[Daniel Jacobowitz <drow at false dot org>]

On Mon, Jun 13, 2005 at 04:48:20PM +1200, Nick Roberts wrote:
>  > It looks like you're doing basically mi_out_rewind.  There's already
>  > several of these in captured_mi_execute_command.  They don't catch this
>  > because throw_exception takes us past them, all the way back to
>  > mi_execute_command.
>  > 
>  > If we add an mi_out_rewind call right here:
>  > 1176              /* The command execution failed and error() was called
>  > 1177                 somewhere */
>  > 
>  > Then the problem goes away.
> 
> So, basically, it just needed one line fix! Hmm...I think I'll look at the
> rest of the MI code before I start re-inventing it again.
> 
> From mi_cmd_data_list_register_values, I removed:
> 
> if (!target_has_registers)
>   {
>     mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers.");
>     return MI_CMD_ERROR;
>   }
> 
> Why do you think it should stay?

Cuz it was late and I wasn't paying a great deal of attention to your
patch, once I figured out the mi_out_rewind problem.  In the interest
of uniformity, let's remove it.  Could you (test and) commit the
obvious patch?

-- 
Daniel Jacobowitz
CodeSourcery, LLC