This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)


> Date: Wed, 27 Apr 2005 19:42:51 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: gdb-patches@sources.redhat.com
> 
> Is it just me, or do others also find the NULL == expression bits a
> bit odd?

There's a school of thought that writing comparisons with a constant
like this prevent errors whereby one uses "=" instead of "==": any
reasonable compiler will yell bloody murder if you say "NULL = foo",
while "foo = NULL" might go unnoticed with some compilers.

However, it looks like the fragment I was patching is the only one
which uses this notation in the while cli directory, so perhaps it's
okay to swap the identifiers to the more traditional form.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]