This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: an i18n sample


Baurjan Ismagulov wrote:
On Sat, Dec 04, 2004 at 08:41:02PM +0100, Baurjan Ismagulov wrote:

On Sun, Nov 28, 2004 at 12:14:59AM +0200, Eli Zaretskii wrote:

Very good, thanks.

Would you like to apply this?


Corrected the concatenation style.

Baurjan, I really appologise here, but people should have known better than to request that you also make cosmetic changes such as switching from this:


@@ -1583,11 +1588,13 @@ _initialize_alpha_tdep (void)
      because the user can always use "999999" or some such for unlimited.  */
   c = add_set_cmd ("heuristic-fence-post", class_support, var_zinteger,
 		   (char *) &heuristic_fence_post,
-		   "\
-Set the distance searched for the start of a function.\n\
-If you are debugging a stripped executable, GDB needs to search through the\n\
-program for the start of a function.  This command sets the distance of the\n\
-search.  The only need to set it is when debugging a stripped executable.",

to this:


+		   _("Set the distance searched for the start of a function.\n"
+		     "If you are debugging a stripped executable, GDB "
+		     "needs to search through the\n"
+		     "program for the start of a function.  This "
+		     "command sets the distance of the\n"
+		     "search.  The only need to set it is when "
+		     "debugging a stripped executable."),

when only a simple markup is necessary.


The former style is used for for a clear and simple reason - it greatly simplifies the challenge of ensuring that the lines are <80 characters. As you observed, our objective should be to make the programmers life easier and that means people should resist the temptation to also request other solely asthetic changes.

Again I apologize.

I've committed the original version of your patch with the tweak Eli suggested.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]