This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] Improve hppa PC reading/unwinding


Hello Mark from Europe!

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
>  
> 	* hppa-tdep.h (hppa_read_pc, hppa_write_pc, hppa_unwind_pc): New
> 	prototypes.
> 	* hppa-tdep.c (hppa_read_pc): Rename from hppa_target_read_pc.
> 	Make global.  Remove HP-UX specific code.
> 	(hppa_write_pc): Rename from hppa_target_write_pc.  Make global.
> 	Remove HP-UX specific code.
> 	(hppa_unwind_pc): Make global.  Remove HP-UX specific code.
> 	(hppa_frame_prev_register_helper): Set "flags" register to zero
> 	for all unwound frames.
> 	(hppa_gdbarch_init): Adjust.
> 	* hppa-hpux-tdep.c (HPPA_HPUX_SS_INSYSCALL): New define.
> 	(hppa_hpux_read_pc, hppa_hpux_write_pc)
> 	(hppa_hpux_unwind_pc): New functions.
> 	(hppa_hpux_init_abi): Set read_pc, write_pc and unwind_pc.

I read the patch, and also tested it with the little example I posted
in the thread you mentioned, and found that it fixed the problem. I
also did a bit of sanity checking and it looks good. I can also test
this change against the testsuite if necessary.

(I really like the fact that the HP/UX part is moved to the hpux tdep).

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]