This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [COMMIT] Fix compilations problem on sparc-sun-solaris2.9
Date: Mon, 15 Nov 2004 08:29:05 -0800
From: Joel Brobecker <brobecker@gnat.com>
> Fallout from the recent term.h fix related to Solaris header
> brandamage. AFAICT "terminal.h" isn't necessary at all in tui-io.c,
> so I removed it. Let's hope there isn't another braindamages systems
> that needs it.
Do you remember the error that you had without your fix? On our side,
we had a failure on this platform too:
> In file included from gdb_curses.h:38,
> from tui/tui-data.h:29,
> from tui/tui-io.c:33:
> /usr/include/term.h:1060: field `Ottyb' has incomplete type
> /usr/include/term.h:1061: field `Nttyb' has incomplete type
> make[1]: *** [tui-io.o] Error 1
Yup, that's exactly the problem I was getting.
We had a patch that I was testing on all our native configuration.
It looks like I can dump it, but I wanted to make sure you address
the same problem.
I did consider something like your patch too, but it didn't feel
right, although it probably is a bit more robust. We can always
consider something like that if the need arises.
Cheers,
Mark