Re: [commit] Add add_setshow_enum_cmd, use in mips

["Eli Zaretskii" <eliz at gnu dot org>]

> Date: Wed, 10 Nov 2004 06:26:48 +0200
> From: "Eli Zaretskii" <eliz@gnu.org>
> CC: cagney@gnu.org, gdb-patches@sources.redhat.com
> 
> > On Tue, Nov 09, 2004 at 10:27:52AM -0500, Andrew Cagney wrote:
> > > This whole thread is stupid.
> > 
> > Thank you for being respectful to your fellow developers.  It's nice to
> > know we're appreciated.
> 
> Same here.

[Having given myself a few hours to cool down, I'm breathing again, and
so can now try to respond rationally rather than emotionally.]

> Before committing a patch as I did, I ask the question:
> 
> ``Could a review significantly alter the change?''
> 
> Conversely, when reviewing a change, I ask:
> 
> ``Is the objection going to significantly alter the change?''
> 
> Here, I cloned a pre-existing interface, adding another variant.  Anyone 
> on this list with the problem I hit would have come up with an identical 
> change.
> 
> Waiting a week would have achieved what?

Let me turn the table, Andrew, and ask you what possible harm could be
caused by posting the patch for review?  At best, no one would have
responded and you'd be committing the patch a week later.  No harm
done; case closed.  At worst, someone _would_ have responded, and the
patch would have been committed 7 days, instead of a week, later,
after some short discussion.  Again, no harm done.

So there're no real disadvantages to posting the patch as an RFA, and
a week doesn't seem like a high price to pay for having everybody
happy.