This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] dwarf2read.c: Use make_function_type instead of lookup_function_type


Corinna Vinschen <vinschen@redhat.com> writes:
> the below patch uses make_function_type instead of lookup_function_type
> in read_subroutine_type.  The reason is that it's important that `ftype'
> is a new type structure for each function and so it shouldn't get reused
> by other function types.  The comment for lookup_function_type indicates
> that it's made to do exactly that, reusing already existing function
> types as they fit.  That's not implemented so far, but it might happen
> at one point, so I suggest to switch to make_function_type in
> read_subroutine_type before something weird happens.
> 
> Ok to check in?
> 
> 
> Corinna
> 
> 	* dwarf2read.c (read_subroutine_type): Call make_function_type
> 	instead of lookup_function_type.

This looks fine.  Thanks!



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]