This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [mips] Getting rid of heuristic proc_desc

From: Andrew Cagney <cagney at gnu dot org>
To: Joel Brobecker <brobecker at gnat dot com>
Cc: Andrew Cagney <cagney at redhat dot com>, gdb-patches at sources dot redhat dot com
Date: Fri, 24 Sep 2004 10:27:47 -0400
Subject: Re: [mips] Getting rid of heuristic proc_desc
References: <20040924001643.GK968@gnat.com>

I was thinking that it should be possible to merge mips32_skip_prologue
inside mips32_heuristic_proc_desc (what a bad name for this function
now).  But I am wondering if this wouldn't make heuristic_proc_desc too
complicated?

Yes, I was thinking on similar lines: - just delete mips32_skip_prologue - have mips32_heuristic* return the CORE_ADDR of the end-of-prologue instead of the proc-descr and use that - and yes, rename heuristic* to something more meaningful (scan prologue?)

The other thing that affects this is skip_prologue_using_sal, perhaphs MIPS should try using that.

I am thinking also that if we were to inline after_prologue inside
mips_skip_prologue, then maybe this would allow us to make some
simplifications...
And maybe all three ideas are orthogonal, and should all be applied?

Hmm.... Not sure which way I should go. Any hunch?

Andrew

References:
- [mips] Getting rid of heuristic proc_desc
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]