This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/intercu] Preserve DIE types
On Tue, Sep 21, 2004 at 10:01:34AM -0500, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@false.org> writes:
> > On Tue, Sep 21, 2004 at 01:25:14AM -0500, Jim Blandy wrote:
> > >
> > > Daniel Jacobowitz <drow@false.org> writes:
> > > > The only solution I could find was to cache this information, specifically
> > > > the DIE -> type mapping.
> > >
> > > I think that's the only correct thing to do.
> > >
> > > > Tested on i686-pc-linux-gnu. OK?
> > >
> > > It looks fine. Just one question: in set_die_type, why do you check
> > > whether cu->per_cu is NULL? Under what circumstances would we be
> > > associating types to dies in a compilation unit that is not considered
> > > "read in"?
> >
> > cu->per_cu != NULL is the flag which indicates that we've seen an
> > inter-compilation-unit reference. If we haven't, then we'll read in
> > this compilation unit but discard it completely when we're done with
> > it.
>
> Okay, that's right --- based on the forms we see used in the abbrev
> table. Thanks. All good, then.
Thanks, checked in.
--
Daniel Jacobowitz