This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] changes to gdb.gdb to use new gdb.exp
All right. This patch is approved, after some formatting changes to
the ChangeLog entry.
Your entry:
2004-09-01 Manoj Iyer <manjo@austin.ibm.com
* gdb.gdb/complaints.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/observer.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/selftest.exp (test_with_self): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/xfullpath.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
Change it to:
2004-09-01 Manoj Iyer <manjo@austin.ibm.com>
* gdb.gdb/complaints.exp (setup_test): Use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/observer.exp (setup_test): Likewise.
* gdb.gdb/selftest.exp (test_with_self): Likewise.
* gdb.gdb/xfullpath.exp (setup_test): Likewise.
. Typo on email address.
. Capitalize the sentence "Use new gdb.exp functionality ..."
. Use "Likewise" to make it easier to read.
We're picky about ChangeLog formatting because some people have emacs
macros and stuff that scan ChangeLog files.
With that ChangeLog entry, your patch is approved. Thanks!
Michael