Re: [RFA/RFC] fix problems with unwinder on mips-irix

[Joel Brobecker <brobecker at gnat dot com>]

Andrew,

I would like to fix the following issue:

> >>>>>2004-07-22  Joel Brobecker  <brobecker@gnat.com>
> >>>>>
> >>>>>        * mips-tdep.c (mips_mdebug_frame_cache): Minor reformatting.
> >>>>>        (set_saved_reg_info): New function.
> >>>>>        (mips32_heuristic_proc_desc): Compute the procedure descriptor
> >>>>>        PROC_REG_OFFSET.
> >>>>>
> >>
> >>>
> >>>It's time to cut our losses and split the mdebug and heuristic cases. 
> >>>Lets work through this change after I've done that.

But you want a "major overhaul" of the mips unwinder as a precondition
to fixing the problem at hand. Could you explain a bit more what
overhaul you are interested in? I don't see what needs to be done.

In particular, you said:

> Two key things to know:
> 
> - with three unwinders handling three different cases previously handled 
> by one, there's a lot of dead code paths.  For instance, 
> mips32_heuristic_proc_desc is now only called by mips_insn32_frame_cache 
> and hence can be inlined there, making it possible for your problem to 
> be solved more locally.

mips32_heuristic_proc_desc is called by heuristic_proc_desc. (And
frankly I find inlining often counter productive, as we end up
with giant function just as we did with decode_line_1).

Thanks,
-- 
Joel